kernel: bump 5.10 to 5.10.169
Add fix: target/linux/generic/backport-5.10/804-0001-net-Remove-WARN_ON_ONCE-sk-sk_forward_alloc-from-sk_.patch[3] All other patches automatically rebased. 3. https://lore.kernel.org/stable/20230227211548.13923-1-kuniyu@amazon.com Signed-off-by: John Audia <therealgraysky@proton.me> (cherry picked from commit b88955aa2294c61f21bdf7014e10d8ea29d0c346)
This commit is contained in:
parent
28e5045f3a
commit
26cc831e44
@ -1,2 +1,2 @@
|
|||||||
LINUX_VERSION-5.10 = .168
|
LINUX_VERSION-5.10 = .169
|
||||||
LINUX_KERNEL_HASH-5.10.168 = b67d2596ba8d30510f743f31899c94c43eaf006a254ff44d7fc6ea26e7ab359c
|
LINUX_KERNEL_HASH-5.10.169 = d9754f6eb55e88214c7aaa7c4831c215f88b48da1d9b40f871b055ff56ebafcf
|
||||||
|
@ -214,7 +214,7 @@
|
|||||||
#include <linux/uaccess.h>
|
#include <linux/uaccess.h>
|
||||||
#include <linux/ipv6.h>
|
#include <linux/ipv6.h>
|
||||||
#include <linux/icmpv6.h>
|
#include <linux/icmpv6.h>
|
||||||
@@ -926,10 +927,10 @@ static void tcp_v6_send_response(const s
|
@@ -927,10 +928,10 @@ static void tcp_v6_send_response(const s
|
||||||
topt = (__be32 *)(t1 + 1);
|
topt = (__be32 *)(t1 + 1);
|
||||||
|
|
||||||
if (tsecr) {
|
if (tsecr) {
|
||||||
|
@ -389,7 +389,7 @@
|
|||||||
if (dc_lsize == 0)
|
if (dc_lsize == 0)
|
||||||
r4k_blast_dcache = (void *)cache_noop;
|
r4k_blast_dcache = (void *)cache_noop;
|
||||||
else if (dc_lsize == 16)
|
else if (dc_lsize == 16)
|
||||||
@@ -1818,6 +1830,17 @@ static void coherency_setup(void)
|
@@ -1827,6 +1839,17 @@ static void coherency_setup(void)
|
||||||
* silly idea of putting something else there ...
|
* silly idea of putting something else there ...
|
||||||
*/
|
*/
|
||||||
switch (current_cpu_type()) {
|
switch (current_cpu_type()) {
|
||||||
@ -407,7 +407,7 @@
|
|||||||
case CPU_R4000PC:
|
case CPU_R4000PC:
|
||||||
case CPU_R4000SC:
|
case CPU_R4000SC:
|
||||||
case CPU_R4000MC:
|
case CPU_R4000MC:
|
||||||
@@ -1864,6 +1887,15 @@ void r4k_cache_init(void)
|
@@ -1873,6 +1896,15 @@ void r4k_cache_init(void)
|
||||||
extern void build_copy_page(void);
|
extern void build_copy_page(void);
|
||||||
struct cpuinfo_mips *c = ¤t_cpu_data;
|
struct cpuinfo_mips *c = ¤t_cpu_data;
|
||||||
|
|
||||||
@ -423,7 +423,7 @@
|
|||||||
probe_pcache();
|
probe_pcache();
|
||||||
probe_vcache();
|
probe_vcache();
|
||||||
setup_scache();
|
setup_scache();
|
||||||
@@ -1940,7 +1972,15 @@ void r4k_cache_init(void)
|
@@ -1949,7 +1981,15 @@ void r4k_cache_init(void)
|
||||||
*/
|
*/
|
||||||
local_r4k___flush_cache_all(NULL);
|
local_r4k___flush_cache_all(NULL);
|
||||||
|
|
||||||
|
@ -29,7 +29,7 @@ This fixes OpenWrt ticket #1485: https://dev.openwrt.org/ticket/1485
|
|||||||
#endif /* __ASM_MACH_BCM47XX_CPU_FEATURE_OVERRIDES_H */
|
#endif /* __ASM_MACH_BCM47XX_CPU_FEATURE_OVERRIDES_H */
|
||||||
--- a/arch/mips/mm/c-r4k.c
|
--- a/arch/mips/mm/c-r4k.c
|
||||||
+++ b/arch/mips/mm/c-r4k.c
|
+++ b/arch/mips/mm/c-r4k.c
|
||||||
@@ -699,7 +699,7 @@ static inline void local_r4k_flush_cache
|
@@ -702,7 +702,7 @@ static inline void local_r4k_flush_cache
|
||||||
map_coherent = (cpu_has_dc_aliases &&
|
map_coherent = (cpu_has_dc_aliases &&
|
||||||
page_mapcount(page) &&
|
page_mapcount(page) &&
|
||||||
!Page_dcache_dirty(page));
|
!Page_dcache_dirty(page));
|
||||||
@ -38,7 +38,7 @@ This fixes OpenWrt ticket #1485: https://dev.openwrt.org/ticket/1485
|
|||||||
vaddr = kmap_coherent(page, addr);
|
vaddr = kmap_coherent(page, addr);
|
||||||
else
|
else
|
||||||
vaddr = kmap_atomic(page);
|
vaddr = kmap_atomic(page);
|
||||||
@@ -721,7 +721,7 @@ static inline void local_r4k_flush_cache
|
@@ -729,7 +729,7 @@ static inline void local_r4k_flush_cache
|
||||||
}
|
}
|
||||||
|
|
||||||
if (vaddr) {
|
if (vaddr) {
|
||||||
|
@ -1360,7 +1360,7 @@ Signed-off-by: David S. Miller <davem@davemloft.net>
|
|||||||
int irq;
|
int irq;
|
||||||
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
||||||
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
||||||
@@ -5013,7 +5013,7 @@ int stmmac_dvr_probe(struct device *devi
|
@@ -5014,7 +5014,7 @@ int stmmac_dvr_probe(struct device *devi
|
||||||
priv->wol_irq = res->wol_irq;
|
priv->wol_irq = res->wol_irq;
|
||||||
priv->lpi_irq = res->lpi_irq;
|
priv->lpi_irq = res->lpi_irq;
|
||||||
|
|
||||||
|
@ -0,0 +1,98 @@
|
|||||||
|
From 35cd2598c910ad6a1cc8bd3f731429b1901abc63 Mon Sep 17 00:00:00 2001
|
||||||
|
From: Kuniyuki Iwashima <kuniyu@amazon.com>
|
||||||
|
Date: Mon, 27 Feb 2023 13:15:48 -0800
|
||||||
|
Subject: [PATCH] net: Remove WARN_ON_ONCE(sk->sk_forward_alloc) from
|
||||||
|
sk_stream_kill_queues().
|
||||||
|
|
||||||
|
commit 62ec33b44e0f7168ff2886520fec6fb62d03b5a3 upstream.
|
||||||
|
|
||||||
|
Christoph Paasch reported that commit b5fc29233d28 ("inet6: Remove
|
||||||
|
inet6_destroy_sock() in sk->sk_prot->destroy().") started triggering
|
||||||
|
WARN_ON_ONCE(sk->sk_forward_alloc) in sk_stream_kill_queues(). [0 - 2]
|
||||||
|
Also, we can reproduce it by a program in [3].
|
||||||
|
|
||||||
|
In the commit, we delay freeing ipv6_pinfo.pktoptions from sk->destroy()
|
||||||
|
to sk->sk_destruct(), so sk->sk_forward_alloc is no longer zero in
|
||||||
|
inet_csk_destroy_sock().
|
||||||
|
|
||||||
|
The same check has been in inet_sock_destruct() from at least v2.6,
|
||||||
|
we can just remove the WARN_ON_ONCE(). However, among the users of
|
||||||
|
sk_stream_kill_queues(), only CAIF is not calling inet_sock_destruct().
|
||||||
|
Thus, we add the same WARN_ON_ONCE() to caif_sock_destructor().
|
||||||
|
|
||||||
|
[0]: https://lore.kernel.org/netdev/39725AB4-88F1-41B3-B07F-949C5CAEFF4F@icloud.com/
|
||||||
|
[1]: https://github.com/multipath-tcp/mptcp_net-next/issues/341
|
||||||
|
[2]:
|
||||||
|
WARNING: CPU: 0 PID: 3232 at net/core/stream.c:212 sk_stream_kill_queues+0x2f9/0x3e0
|
||||||
|
Modules linked in:
|
||||||
|
CPU: 0 PID: 3232 Comm: syz-executor.0 Not tainted 6.2.0-rc5ab24eb4698afbe147b424149c529e2a43ec24eb5 #2
|
||||||
|
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014
|
||||||
|
RIP: 0010:sk_stream_kill_queues+0x2f9/0x3e0
|
||||||
|
Code: 03 0f b6 04 02 84 c0 74 08 3c 03 0f 8e ec 00 00 00 8b ab 08 01 00 00 e9 60 ff ff ff e8 d0 5f b6 fe 0f 0b eb 97 e8 c7 5f b6 fe <0f> 0b eb a0 e8 be 5f b6 fe 0f 0b e9 6a fe ff ff e8 02 07 e3 fe e9
|
||||||
|
RSP: 0018:ffff88810570fc68 EFLAGS: 00010293
|
||||||
|
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
|
||||||
|
RDX: ffff888101f38f40 RSI: ffffffff8285e529 RDI: 0000000000000005
|
||||||
|
RBP: 0000000000000ce0 R08: 0000000000000005 R09: 0000000000000000
|
||||||
|
R10: 0000000000000ce0 R11: 0000000000000001 R12: ffff8881009e9488
|
||||||
|
R13: ffffffff84af2cc0 R14: 0000000000000000 R15: ffff8881009e9458
|
||||||
|
FS: 00007f7fdfbd5800(0000) GS:ffff88811b600000(0000) knlGS:0000000000000000
|
||||||
|
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
|
||||||
|
CR2: 0000001b32923000 CR3: 00000001062fc006 CR4: 0000000000170ef0
|
||||||
|
Call Trace:
|
||||||
|
<TASK>
|
||||||
|
inet_csk_destroy_sock+0x1a1/0x320
|
||||||
|
__tcp_close+0xab6/0xe90
|
||||||
|
tcp_close+0x30/0xc0
|
||||||
|
inet_release+0xe9/0x1f0
|
||||||
|
inet6_release+0x4c/0x70
|
||||||
|
__sock_release+0xd2/0x280
|
||||||
|
sock_close+0x15/0x20
|
||||||
|
__fput+0x252/0xa20
|
||||||
|
task_work_run+0x169/0x250
|
||||||
|
exit_to_user_mode_prepare+0x113/0x120
|
||||||
|
syscall_exit_to_user_mode+0x1d/0x40
|
||||||
|
do_syscall_64+0x48/0x90
|
||||||
|
entry_SYSCALL_64_after_hwframe+0x72/0xdc
|
||||||
|
RIP: 0033:0x7f7fdf7ae28d
|
||||||
|
Code: c1 20 00 00 75 10 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 ee fb ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 37 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
|
||||||
|
RSP: 002b:00000000007dfbb0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
|
||||||
|
RAX: 0000000000000000 RBX: 0000000000000004 RCX: 00007f7fdf7ae28d
|
||||||
|
RDX: 0000000000000000 RSI: ffffffffffffffff RDI: 0000000000000003
|
||||||
|
RBP: 0000000000000000 R08: 000000007f338e0f R09: 0000000000000e0f
|
||||||
|
R10: 000000007f338e13 R11: 0000000000000293 R12: 00007f7fdefff000
|
||||||
|
R13: 00007f7fdefffcd8 R14: 00007f7fdefffce0 R15: 00007f7fdefffcd8
|
||||||
|
</TASK>
|
||||||
|
|
||||||
|
[3]: https://lore.kernel.org/netdev/20230208004245.83497-1-kuniyu@amazon.com/
|
||||||
|
|
||||||
|
Fixes: b5fc29233d28 ("inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().")
|
||||||
|
Reported-by: syzbot <syzkaller@googlegroups.com>
|
||||||
|
Reported-by: Christoph Paasch <christophpaasch@icloud.com>
|
||||||
|
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
|
||||||
|
Reviewed-by: Eric Dumazet <edumazet@google.com>
|
||||||
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
||||||
|
---
|
||||||
|
net/caif/caif_socket.c | 1 +
|
||||||
|
net/core/stream.c | 1 -
|
||||||
|
2 files changed, 1 insertion(+), 1 deletion(-)
|
||||||
|
|
||||||
|
--- a/net/caif/caif_socket.c
|
||||||
|
+++ b/net/caif/caif_socket.c
|
||||||
|
@@ -1020,6 +1020,7 @@ static void caif_sock_destructor(struct
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
sk_stream_kill_queues(&cf_sk->sk);
|
||||||
|
+ WARN_ON(sk->sk_forward_alloc);
|
||||||
|
caif_free_client(&cf_sk->layer);
|
||||||
|
}
|
||||||
|
|
||||||
|
--- a/net/core/stream.c
|
||||||
|
+++ b/net/core/stream.c
|
||||||
|
@@ -209,7 +209,6 @@ void sk_stream_kill_queues(struct sock *
|
||||||
|
sk_mem_reclaim(sk);
|
||||||
|
|
||||||
|
WARN_ON(sk->sk_wmem_queued);
|
||||||
|
- WARN_ON(sk->sk_forward_alloc);
|
||||||
|
|
||||||
|
/* It is _impossible_ for the backlog to contain anything
|
||||||
|
* when we get here. All user references to this socket
|
@ -29,7 +29,7 @@ Signed-off-by: David S. Miller <davem@davemloft.net>
|
|||||||
|
|
||||||
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
||||||
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
|
||||||
@@ -5046,6 +5046,10 @@ int stmmac_dvr_probe(struct device *devi
|
@@ -5047,6 +5047,10 @@ int stmmac_dvr_probe(struct device *devi
|
||||||
reset_control_reset(priv->plat->stmmac_rst);
|
reset_control_reset(priv->plat->stmmac_rst);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -40,7 +40,7 @@ Signed-off-by: David S. Miller <davem@davemloft.net>
|
|||||||
/* Init MAC and get the capabilities */
|
/* Init MAC and get the capabilities */
|
||||||
ret = stmmac_hw_init(priv);
|
ret = stmmac_hw_init(priv);
|
||||||
if (ret)
|
if (ret)
|
||||||
@@ -5260,6 +5264,7 @@ int stmmac_dvr_remove(struct device *dev
|
@@ -5261,6 +5265,7 @@ int stmmac_dvr_remove(struct device *dev
|
||||||
phylink_destroy(priv->phylink);
|
phylink_destroy(priv->phylink);
|
||||||
if (priv->plat->stmmac_rst)
|
if (priv->plat->stmmac_rst)
|
||||||
reset_control_assert(priv->plat->stmmac_rst);
|
reset_control_assert(priv->plat->stmmac_rst);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user